Fix CI test flakes#3299
Conversation
Commit ea75775 explicitly added tolerance to the TCP test, but references BOSH. I've extended it to BOSH - no idea if TCP is in error.
…case of a Netty race condition
guusdk
left a comment
There was a problem hiding this comment.
I don't really like the blunt retries - it hides a problem to the point where having the test may not reliably prove much any more.
I was considering to simply disable these tests, until we can get them more stable.
Happy to test these changes to see if they make a difference, but meh - I don' have high hopes.
guusdk
left a comment
There was a problem hiding this comment.
I don't really like the blunt retries - it hides a problem to the point where having the test may not reliably prove much any more.
I was considering to simply disable these tests, until we can get them more stable.
Happy to test these changes to see if they make a difference, but meh - I don' have high hopes.
Me neither, but in this case, it feels like a necessary evil, and didn't feel altogether all that evil.... Retries are added to 2 places:
|
ea75775 added a lenience, but gasve it to TCP rather than BOSH connection
Mockito was causing UnfinishedStubbingException on XMPPServer.setInstance(newMock)
Herein lie attempts to fix the recent test flakes in CI. I believe them all to be reasonable changes or reasonable compromises.