DRAFT JPRO-212 Dev Mode with ScenicView#810
Draft
FlorianKirmaier wants to merge 3 commits intoikmdev:mainfrom
Draft
DRAFT JPRO-212 Dev Mode with ScenicView#810FlorianKirmaier wants to merge 3 commits intoikmdev:mainfrom
FlorianKirmaier wants to merge 3 commits intoikmdev:mainfrom
Conversation
Contributor
|
@FlorianKirmaier great work! I need to digest your suggestions a bit and share this with the architecture team. Not sure why the build failed. |
Contributor
Author
|
Hm, looks to my like something in the CI pipeline glitches, because i added the sandec repo for the ScenicView fork. I'll try to report the bug with the subproject/jpackager/javafx-maven-plugin. |
Contributor
Author
|
I've created ticket for the problem with JLink: openjfx/javafx-maven-plugin#187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a developer mode for the app.
It makes it especially easy to open ScenicView with a shortcut, which greatly simplifies development.
Having all the dev-tools enabled by default can be a significant boost to developer productivity.
You can start the app with the following commands:
./mvnw -f dev javafx:run./mvnw -f dev -Pjpro jpro:runFuture ideas:
Possible issues:
JavaFX plugin:
I noticed that I cannot use "application" as a subproject as long as a jpackager goal is configured.
For this PR, I removed the goals. I am not sure if they are actually used, since there are other goals for creating the installer under the
create-installerprofile. This might block the PR for now.ScenicView dependency:
I am using a slightly modified version of ScenicView, currently hosted in our Sandec repository.
If using this dependency causes problems, it could also block the PR.
If needed, the dependency can be published to Maven Central, which may take some time.
Bonus:
Removed the
LoginFeatureFlagpart, as it was overengineered without real benefit.