ext/com_dotnet: release the held IUnknown in com_get_active_object()#103
Closed
iliaal wants to merge 1 commit into
Closed
ext/com_dotnet: release the held IUnknown in com_get_active_object()#103iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
The cleanup block guarded on `unk` but released `obj`, so a successful GetActiveObject() released the IDispatch proxy twice (once already under the obj guard) and never released the IUnknown it returned, leaking it. Release `unk` so each interface pointer is released exactly once.
Owner
Author
|
Submitted upstream as php#22378. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In com_get_active_object() the cleanup block guarded on
unkbut called IUnknown_Release(obj). On a successful GetActiveObject() that releases the IDispatch proxy twice (it is already released under the obj guard) and leaks the IUnknown returned by GetActiveObject; on a QueryInterface failure obj is NULL so it degrades to IUnknown_Release(NULL). Releaseunkso each interface pointer is released exactly once. This is Windows-only COM code that I could not build or run on Linux, and the corrupting path needs a live ROT-registered object, so there is no automated test; verified by inspection.