Fix use-after-free when ArrayObject sort comparator replaces backing store#81
Closed
iliaal wants to merge 1 commit into
Closed
Fix use-after-free when ArrayObject sort comparator replaces backing store#81iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
…store spl_array_method() caches the backing HashTable pointer across a user-supplied comparator (uasort/uksort and the sort handlers). The comparator can re-enter __construct() or __unserialize(), which route through spl_array_set_array() and swap intern->array out from under the cached pointer, leaving the post-sort cleanup to release and dereference freed memory. Mirror the nApplyCount guard the other mutators already use so replacing the backing store during a sort throws instead.
Owner
Author
|
Submitted upstream as php#22310. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spl_array_method() caches the backing HashTable pointer across the user-supplied sort comparator. A comparator that re-enters __construct() (or __unserialize()) routes through spl_array_set_array(), which unlike the other ArrayObject mutators had no nApplyCount guard, so it swaps intern->array out from under the cached pointer and the post-sort cleanup releases then dereferences freed memory. Reachable from pure userland; valgrind reports an invalid read and the process segfaults. Add the nApplyCount guard the dimension writers and exchangeArray() already use.