Fix MIME charset sniffing advancing by name length not value length#90
Closed
iliaal wants to merge 2 commits into
Closed
Fix MIME charset sniffing advancing by name length not value length#90iliaal wants to merge 2 commits into
iliaal wants to merge 2 commits into
Conversation
iliaal
force-pushed
the
fix-libxml-mime-sniff
branch
from
a5603ec to
360149c
Compare
iliaal
force-pushed
the
fix-libxml-mime-sniff
branch
from
360149c to
6717f6d
Compare
php_libxml_sniff_charset_from_string() advanced the parse cursor by the parameter name length after collecting an unquoted parameter value (WHATWG mime-sniff step 11.9.1), instead of the value length. When a Content-Type parameter before charset had a name and value of different lengths, the cursor misaligned and the charset parameter was missed, so document loading fell back to the wrong encoding. Closes phpGH-22343
iliaal
force-pushed
the
fix-libxml-mime-sniff
branch
from
6717f6d to
a2a9053
Compare
Owner
Author
|
Submitted upstream as php#22343. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_libxml_sniff_charset_from_string() advanced the parse cursor by the parameter name length after collecting an unquoted parameter value (WHATWG mime-sniff step 11.9.1), instead of the value length. A Content-Type whose parameter before charset has a name and value of different lengths (e.g.
text/html; abcd=ef;charset=ISO-8859-1) misaligns the cursor so the charset parameter is missed, and Dom\HTMLDocument loading falls back to the wrong encoding. The existing createFromFile HTTP-header test only used equal-length name=value pairs, which masked it.