Fix leak of preserved input string with FILTER_THROW_ON_FAILURE#92
Closed
iliaal wants to merge 3 commits into
Closed
Fix leak of preserved input string with FILTER_THROW_ON_FAILURE#92iliaal wants to merge 3 commits into
iliaal wants to merge 3 commits into
Conversation
iliaal
force-pushed
the
fix-filter-throw-leak
branch
from
3dd4b3e to
020bb7e
Compare
iliaal
force-pushed
the
fix-filter-throw-leak
branch
from
020bb7e to
842f3f2
Compare
php_zval_filter() copies the filtered value so it can be quoted in the FilterFailedException message, then released the copy with zend_string_delref(), which only decrements the refcount. When the input is a non-string scalar that convert_to_string() turns into a fresh heap string, the copy was the sole owner and leaked one string per call on both the failure and the success path. Use zend_string_release() so it is freed at refcount zero. Closes phpGH-22339
Owner
Author
|
Submitted upstream as php#22339. |
iliaal
force-pushed
the
fix-filter-throw-leak
branch
from
842f3f2 to
38857bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_zval_filter() copies the filtered value to quote it in the FilterFailedException message, then released the copy with zend_string_delref(), which only decrements the refcount. When the input is a non-string scalar that convert_to_string() turns into a fresh heap string, the copy is the sole owner and leaks one string per call, on both the failure and success paths. Use zend_string_release() so it is freed at refcount zero.