zend_ast: Escape control bytes in exported string literals#98
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
The AST pretty-printer rendered string literals in single quotes, appending each byte verbatim. A literal containing a NUL kept the byte in the resulting string, but assert() hands that string to zend_throw_exception() as a const char*, so the failure message was truncated at the first NUL (the closing of the expression was lost). Render literals that contain a control byte double-quoted via zend_ast_export_qstr(), which escapes those bytes as octal. The embedded NUL no longer survives, so the message is complete, and the byte is shown in escaped form. Strings without control bytes are unchanged. Fixes phpGH-22290
Owner
Author
|
Promoted upstream to php#22350 (base PHP-8.4). Closing this fork PR; keeping the branch since the upstream PR's head points at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert() failure messages were truncated at the first NUL byte when the asserted expression contained a string literal with a NUL, e.g. assert(!str_contains($string, "\x00")) produced only assert(!str_contains($string, '. The AST pretty-printer rendered string literals single-quoted with raw bytes; the NUL survived in the zend_string but assert() passes it to zend_throw_exception() as a const char*, which re-measures with strlen. Literals containing a control byte are now rendered double-quoted via zend_ast_export_qstr() so the byte is escaped as octal and no embedded NUL remains. Fixes php#22290.