Support PHP 8.1#303
Merged
Merged
Conversation
The only 8.3+ dependency was the class-entry default_object_handlers field; guard the assignment with PHP_VERSION_ID >= 80300. On 8.1/8.2 each create_object handler already sets intern->std.handlers, the correct per-object mechanism there. Lower the floor to 8.1.0 in config.m4 and composer.json, add 8.1/8.2 to the linux/windows CI matrices and the release build matrix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lowers the minimum from 8.3 to 8.1.
Blocker + fix
The only 8.3+ dependency was the class-entry
default_object_handlersfield assigned in theREGISTER_EXCEL_CLASSmacro. Guarded with#if PHP_VERSION_ID >= 80300. No#elseneeded: eachcreate_objecthandler already setsintern->std.handlersdirectly (verified across all 12 classes), which is the correct per-object mechanism on 8.1/8.2.Floor + CI
config.m4: vernum gate80300->80100, error message updated to "8.1.0 or later".composer.json:>=8.3->>=8.1.README.markdown: "PHP 8.1+ minimum".php-version-list(windows.yml), andbuild_matrixin .release-config.Verification
Built clean (0 warnings, 0 errors) and ran the full suite against local ASAN PHP 8.1.34 and 8.2.31:
Both skips are license-gated (
isLicensed()/ licensed row-0 access) with no libxl key set — environment, not version. Runtime smoke test confirms object handlers wire correctly on 8.1.