Open
Conversation
Collaborator
Author
|
@NoahCardoza I've implemented #595 here - I'll take do a deeper review tomorrow but feel free to take a look too (if you want, no obligation!) |
NoahCardoza
reviewed
Feb 17, 2026
| * @param identifier - The issue identifier (number or string) | ||
| * @returns Formatted issue ID string | ||
| */ | ||
| static formatIssueId(providerType: IssueTrackerProviderType, identifier: string | number): string { |
Contributor
There was a problem hiding this comment.
My original plan was to have each issue tracker service implement it's own static formatIssueId method, and then use this factory method to route between them in areas where we didn't need a whole issue tracker service instance.
That way there is a single source of truth and implementing a new service doesn't require knowing this has to be updated too. We could implement a typescript guard to ensure an error is thrown if a new provider is added and didn't update this switch-case.
NoahCardoza
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatIssueIdmethod toIssueTrackerinterface and static utility onIssueTrackerFactoryso issue IDs are formatted correctly per provider (GitHub:#123, Jira:QLH-4404, Linear:ENG-123)#prefixes in core commands (start,finish,enhance,cleanup,commit,plan) and lib files (PRManager,LoomManager,LoomLauncher,IssueEnhancementService) to useformatIssueIdISSUE_PREFIXtemplate variable to Handlebars templates so agent prompts render issue IDs correctly for all providersTest plan
pnpm buildpassesIssue #123Issue QLH-4404(no#)Issue ENG-123(no#)Closes #595, closes #596, closes #598, closes #599, closes #600, closes #601