parse JFIF APP0 sections and expose Density with DensityUnits#115
parse JFIF APP0 sections and expose Density with DensityUnits#115cormacrelf wants to merge 1 commit intoimage-rs:masterfrom
Conversation
a1dc5bd to
cee1e36
Compare
|
The one failure on stable-1.28.0 is because Seems pretty weird to me as I thought the edition flag was stable already. Maybe it's a bad message because using |
| restart_interval: u16, | ||
| color_transform: Option<AdobeColorTransform>, | ||
| is_jfif: bool, | ||
| jfif_app0: Option<JfifApp0>, |
There was a problem hiding this comment.
Are color_transform and jfif_app0 mutually exclusive? If so, perhaps this could hold an AppData or Option instead?
|
This PR generally looks good to me, though I agree that it should probably either fully decode thumbnail images or just ignore them. |
|
Having the ability to get the PixelDensity from a decoded image would be really great! What is missing here, so the MR can get merged? |
|
We're no longer adding new features since the crate is in maintenance mode:
|
See image-rs/image#1067
Possible improvements
png::PixelDimensions, which is not really an accurate name because it doesn't represent the size of a pixel, but the density of an image.dbg!()that the reftest images with JFIF APP0 sections could decode the density information.