Closed
Conversation
Contributor
|
This project is in maintenance mode and not seeking further development. Additionally, reformatting PRs like this can really only be done by maintainers because manually reviewing every change in a PR like this would be both time consuming and pointless |
Author
|
We rely on the lossless functionality and have related fixes to submit. c.f. https://github.com/franklin-ai/jpeg-decoder/commits/main/ If you would like to re-do this PR yourself, here are the steps that I took
That is all. |
Contributor
|
This isn't an improvement. Every rustfmt change is making the code slightly worse, and peppers it with If you have an editor that unconditionally reformats, then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR #271 over a year old and has no feedback.
Older open PRs, also no feedback
I didnt see any closed PRs.