Open
Conversation
added 2 commits
January 7, 2022 18:21
…on alignment and layout
* master: clean up linkGroups; add twig file; update site-footer clean up linkGroup; add twig file show -primary, -secondary, and -lightGray modifiers within layer variants; collate layers remove legacy .-pull-left; better document how to use candlepin 5.1.3 # Conflicts: # resources/styles/organisms/site-footer/site-footer.twig
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved layer__actions out of the layer—calltoAction variant as we use these in all sorts of layers, not just a dedicated variant
after moving it, modified the styles so it doesn’t automatically center, and so we can account for more than one button, and have them spaced out properly, wrapping it they need to (especially on mobile) – these 2 buttons can now be seen on the homepage and on layer—calltoAction
layer__actions also needed a modifier so we can center them if we want (which I added into layer—callToAction.twig)
there was a crawler appearing on the homepage because of two issues:
i’d like to re-do the footer completely at some point but it doesn’t cause crawlbar anymore