fix: prevent panic on IOTA connection failure via lazy initialization#44
Merged
nanderstabel merged 4 commits intobetafrom Mar 3, 2026
Merged
fix: prevent panic on IOTA connection failure via lazy initialization#44nanderstabel merged 4 commits intobetafrom
nanderstabel merged 4 commits intobetafrom
Conversation
…on and improved handler attachment
daniel-mader
previously approved these changes
Mar 3, 2026
daniel-mader
approved these changes
Mar 3, 2026
|
🎉 This PR is included in version 1.0.0-beta.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Mar 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Restructures the
Resolverto initialize IOTA network clients lazily instead of eagerly at startup.Changes:
Resolverto useRwLockand double-checked locking for on-demand initialization.iota_clientsinto a single-networkget_iota_clienthelper. (ensures that one failing IOTA network (client) does not affect initialization of the other IOTA network client initialization)Links to any relevant issues
Resolver::newpanicking on startup inidentity-walletandssi-agent.How the change has been tested
Added unit tests:
concurrent_resolutions_do_not_deadlockiota_failure_does_not_break_basic_resolverTested startup 'manually' in identity-wallet and ssi-agent.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.