Update safety PNS code and add chronaxie/rheobase Python port#385
Update safety PNS code and add chronaxie/rheobase Python port#385LeoMcBills wants to merge 14 commits into
Conversation
Reorganize PNS algorithm from utils/ to safety/pns/ and update all imports. Establishes a dedicated safety subsystem for better code organization.
|
Wouldn't it make more sense to keep this as a separate package, which we add as an additional dependency so that we can call the functions in |
|
I agree with @schuenke, this can be an optional dependency. |
|
Hi @schuenke, @btasdelen, @LeoMcBills — thank you all for pushing this forward. I think improving the structure of One point I would like us to be careful about is vendor neutrality, especially because this is safety-related code. My understanding is that the current So if we restructure I just want to make sure that, because this touches safety, PyPulseq remains transparent and vendor-neutral. |
safe_pns.pywith the latest safety branch changes.src/pypulseq/safety/pns/chronaxie_rheobase.py.