Fix compilation with OTP29#611#219
Merged
elbrujohalcon merged 2 commits intomainfrom Mar 20, 2026
Merged
Conversation
```
===> Compiling src/wpool_time_checker.erl failed
┌─ src/wpool_time_checker.erl:
│
137 │ _ = [_ = catch Mod:Fun(Args) || {Mod, Fun} <- Handlers],
│ ╰── 'catch ...' is deprecated; please use 'try ... catch ... end' instead.
Compile directive 'nowarn_deprecated_catch' can be used to suppress
warnings in selected modules.
```
This also has the advantage that, `catch` forcefully creates a
stacktrace, only to be discarded, which is a performance waste; using
`try-catch` we can explicitly say we don't want the stacktrace, and the
stack won't be threaded.
Also took the chance to update some dependencies and plugins.
elbrujohalcon
approved these changes
Mar 20, 2026
Member
elbrujohalcon
left a comment
elbrujohalcon
left a comment
There was a problem hiding this comment.
Feel free to generate a new release if you need it, @NelsonVides
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with OTP29:
This also has the advantage that,
catchforcefully creates astacktrace, only to be discarded, which is a performance waste; using
try-catchwe can explicitly say we don't want the stacktrace, and thestack won't be threaded.
Also took the chance to update some dependencies and plugins.