Bounding box queries can use private coordinates #68#419
Open
Bounding box queries can use private coordinates #68#419
Conversation
Member
pleary
commented
Jan 3, 2024
- Refactors how query filters are applied for collection project trusting
- Core logic about trusting is extracted, and can be applied to place filters and also bounding box filters, which resolves bounding box queries don't use private coordinates, even for obs you have permission to see #68
…s based on project trust
kueda
approved these changes
Jan 4, 2024
Contributor
kueda
left a comment
There was a problem hiding this comment.
This looks good and addresses the issue raised in #68, so I don't think there are any blocking problems. That said, I would like to see some integration tests showing that this is working, something along the lines of
describe( "filtering by bounding box", ( ) => {
describe( "including an obscured observation's true coordinates but not the obscured coordinates", ( ) => {
it( "should return the observation when viewed by the observer" );
it( "should return the observation when viewed someone the observer trusts" );
it( "should not return the observation when viewed by someone the observer doesn't trust" );
} );
describe( "including an obscured observation's obscured coordinates but not the true coordinates", ( ) => {
it( "should not return the observation when viewed by the observer" );
it( "should not return the observation when viewed someone the observer trusts" );
it( "should return the observation when viewed by someone the observer doesn't trust" );
} );
} );
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.