ci: parallelize unit and integration tests across 4 GPU instances#1185
Merged
garrett4wade merged 4 commits intomainfrom Apr 16, 2026
Merged
ci: parallelize unit and integration tests across 4 GPU instances#1185garrett4wade merged 4 commits intomainfrom
garrett4wade merged 4 commits intomainfrom
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Split the CI matrix from 2 jobs (sglang, vllm) to 4 by adding a test_type dimension (unit, integration). Each variant now provisions two separate GCP runners that execute in parallel, reducing overall wall-clock time. Key changes: - Add test_type matrix dimension to provision-runner, unit-tests, cleanup jobs - Add conditional steps: unit tests run only on test_type=unit, SFT+GRPO on integration - Update runner labels and instance names to include test_type for isolation
The tests sent application/octet-stream but the body was JSON-serialized data. FastAPI passed raw bytes instead of parsing JSON, causing 'bytes' object has no attribute 'nbytes' in rtensor._store_local. Key changes: - Change Content-Type from application/octet-stream to application/json - Clear _storage_stats in test fixture to prevent cross-test leaks
9159038 to
47b248e
Compare
… model tests Add missing @torch.no_grad() to test_dcp_save_load_weights to prevent in-place param.zero_() error on grad-requiring leaf tensors, matching the existing decorator on test_hf_save_load_weights. Mock dist.get_rank in test_create_device_model_applies_use_kernels to handle the new rank check added by f34bea8 (memory_efficient_load meta device optimization) when distributed is not initialized.
Validate that raw_payload is a dict before unpacking into BatchShardRequest. Non-dict JSON bodies (e.g. arrays) raised TypeError instead of ValidationError, bypassing the 400 handler and falling through to the 500 catch-all.
garrett4wade
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split the CI matrix from 2 jobs (sglang, vllm) to 4 by adding a
test_typedimension (unit,integration) to the existingvariantmatrix. Each variant now provisions two separate GCP runners that execute in parallel, reducing overall wall-clock time for the CI pipeline.Fixed unit test bugs introduced by previous PRs.
Related Issue
N/A
Type of Change
Checklist
pre-commit run --all-files)./docs/build_all.sh)main/review-prcommand/create-prBreaking Change Details (if applicable):
N/A
Additional Context
The 2x2 matrix produces these 4 parallel jobs:
Files changed:
.github/workflows/test-areal.ymlNeed help? Check the Contributing Guide or ask in
GitHub Discussions!