fix: FSDP initialization for set-valued wrap class names#1187
Open
Wangxiaoxiaoa wants to merge 3 commits intoinclusionAI:mainfrom
Open
fix: FSDP initialization for set-valued wrap class names#1187Wangxiaoxiaoa wants to merge 3 commits intoinclusionAI:mainfrom
Wangxiaoxiaoa wants to merge 3 commits intoinclusionAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a _normalize_wrap_class_names helper function within apply_fsdp2 to standardize the handling of transformer class names, ensuring they are consistently treated as lists regardless of whether the input is a string, None, or an iterable. The review feedback suggests an optimization for this helper function to avoid creating a shallow copy when the input is already a list, thereby reducing unnecessary allocations.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalize FSDP transformer wrap class names before using them during
initialization.
In some cases, these names may be provided as a
setrather than alistortuple. The previous implementation assumed the value was indexable and couldfail with:
TypeError: 'set' object is not subscriptableThis change normalizes the value before validation and wrapping logic.
Related Issue
Fixes #1186
Type of Change
Checklist
pre-commit run --all-files)./docs/build_all.sh)main/review-prcommand/create-prBreaking Change Details (if applicable):
N/A
Additional Context
This is a minimal compatibility fix. It does not change behavior for existing
strorlistinputs.