fix(bcs): extend provider SSE idle timeout#323
Open
vzvince wants to merge 4 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
vzvince
force-pushed
the
codex/provider-sse-idle-15m
branch
from
July 22, 2026 07:52
cef0d75 to
acdc6e3
Compare
vzvince
marked this pull request as ready for review
July 22, 2026 08:24
vzvince
requested review from
RaymondHX,
carolynli and
questchaos
as code owners
July 22, 2026 08:24
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
|
@codex please review this pr. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acdc6e3695
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
RaymondHX
approved these changes
Jul 24, 2026
RaymondHX
approved these changes
Jul 24, 2026
RaymondHX
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Long-running Provider operations can legitimately produce no response-body data for more than two minutes. The previous application idle timeout and reqwest read timeout could close those healthy SSE streams before the Provider emitted its next event or heartbeat.
Separating response-header timeout handling from response-body liveness allows established SSE streams to remain idle for up to 15 minutes without allowing the initial Provider request to wait indefinitely for headers.
User impact
Provider SSE runs can now tolerate longer silent processing periods. Any SSE body chunk, including a standard SSE comment heartbeat, continues to reset the application idle timer.
Testing
cargo test -p bcs-provider-httpcargo check -p bcs-provider-http