add show errors on submit#71
Open
koryteg wants to merge 1 commit intoindexiatech:masterfrom
koryteg:submit-show-errors
Open
add show errors on submit#71koryteg wants to merge 1 commit intoindexiatech:masterfrom koryteg:submit-show-errors
koryteg wants to merge 1 commit intoindexiatech:masterfrom
koryteg:submit-show-errors
Conversation
josemarluedke
added a commit
to josemarluedke/ember-forms
that referenced
this pull request
Dec 29, 2014
Copy from indexiatech#71
josemarluedke
added a commit
to josemarluedke/ember-forms
that referenced
this pull request
Jan 16, 2015
Copy from indexiatech#71
ultimatemonty
pushed a commit
to ultimatemonty/ember-forms
that referenced
this pull request
Mar 24, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sets "canShowErrors" attribute to true on all fields if validation fails. not sure if you want to add this feature but it seems like a pretty common case.
it also does this recursively because that seems like the best way to handle forms with relationships (or forms within forms)