Conversation
xo pulls in 340+ transitive deps and fights the codebase on camelCase and await-in-loop. Biome gives the same formatting and lint coverage with a single native binary, no eslint-disable comments, and faster check times. - Add biome.json adapted from ecosystems-rebuilder.js config - Remove xo devDependency and xo.config.js - Strip all eslint-disable comments from src/ and test/ - Auto-fix formatting (spacing, template literals, hook deps) - Update CLAUDE.md linting section - All 90 tests pass, 0 lint errors Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Separate linting from the test matrix so format and lint failures surface as their own check badge instead of running redundantly on both Node 20 and 22. Tests no longer block on lint and vice versa. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace xo (ESLint wrapper, 340+ transitive deps) with Biome as the project linter and formatter.
Why
xo required
eslint-disablecomments throughout the codebase for spec-mandatedsnake_casefields and intentionalawait-in-looppatterns. Biome provides equivalent lint and formatting coverage as a single native binary with faster check times and no suppression comments needed.Changes
Add
biome.json(adapted from ecosystems-rebuilder.js config: single quotes, spaces, no trailing commas, 100-char line width)Remove
xodevDependency andxo.config.jsStrip all
eslint-disable/eslint-enablecomments fromsrc/andtest/Auto-fix formatting across 30 files (spacing, template literals, React hook dependencies, import organization)
Update
pnpm lint/pnpm lint:fixscripts to usebiome checkpnpm test— all 90 tests passpnpm lint— 0 errors, 3 warnings (idiomaticwhile ((match = regex.exec()))assign-in-expression)Verify CI passes