Open
Conversation
Owner
|
Thanks for pointing this out, it's definitely not ideal to be issuing spurious network requests. I had thought that by using an SVG sprite for the icons that the sprite would be loaded once then each icon would be fetched from the already loaded sprite. I'll check why this is not the case first as I'd rather avoid adding more code if possible, the svg sprite should be cached by the browser so using native functionality is a cheap easy win. I'll reply when I've tested it more, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, first of all, it's a great component.
While debugging ,i've noticed, that every sorting fires a network request - which some would consider as suboptimal :)
This PR offers one way to tackle this, fetching the svg once on init and inserting it hidden into the dom.