Skip to content

Use OneKernel directly #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Jun 2, 2026
+24 −40
Merged

Use OneKernel directly #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fccbd78
feat: use OneKernel directly when possible
alexfikl Jun 2, 2026
02d620f
chore: update baseline
alexfikl Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 18 additions & 34 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@
"code": "reportUnusedImport",
"range": {
"startColumn": 57,
"endColumn": 70,
"endColumn": 66,
"lineCount": 1
}
},
Expand Down Expand Up @@ -855,7 +855,7 @@
"code": "reportUnusedImport",
"range": {
"startColumn": 57,
"endColumn": 70,
"endColumn": 66,
"lineCount": 1
}
},
Expand Down Expand Up @@ -29145,6 +29145,14 @@
"lineCount": 1
}
},
{
"code": "reportAbstractUsage",
"range": {
"startColumn": 19,
"endColumn": 18,
"lineCount": 4
}
},
{
"code": "reportCallIssue",
"range": {
Expand Down Expand Up @@ -29273,6 +29281,14 @@
"lineCount": 1
}
},
{
"code": "reportAbstractUsage",
"range": {
"startColumn": 19,
"endColumn": 18,
"lineCount": 4
}
},
{
"code": "reportCallIssue",
"range": {
Expand Down Expand Up @@ -44517,38 +44533,6 @@
"lineCount": 1
}
},
{
"code": "reportUnknownVariableType",
"range": {
"startColumn": 12,
"endColumn": 18,
"lineCount": 1
}
},
{
"code": "reportOptionalSubscript",
"range": {
"startColumn": 21,
"endColumn": 48,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 49,
"endColumn": 70,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 49,
"endColumn": 55,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
Expand Down
2 changes: 1 addition & 1 deletion examples/layerpot-3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import numpy as np

from sumpy.kernel import HelmholtzKernel, LaplaceKernel, one_kernel_2d # noqa
from sumpy.kernel import HelmholtzKernel, LaplaceKernel, OneKernel # noqa
from sumpy.visualization import FieldPlotter

from pytential import bind, sym
Expand Down
2 changes: 1 addition & 1 deletion examples/layerpot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import numpy as np

from meshmode.mesh.generation import drop, ellipse, starfish # noqa: F401
from sumpy.kernel import HelmholtzKernel, LaplaceKernel, one_kernel_2d # noqa: F401
from sumpy.kernel import HelmholtzKernel, LaplaceKernel, OneKernel # noqa: F401
from sumpy.visualization import FieldPlotter

from pytential import bind, sym
Expand Down
2 changes: 1 addition & 1 deletion experiments/maxwell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pyopencl as cl
from sumpy.visualization import FieldPlotter
#from mayavi import mlab
from sumpy.kernel import one_kernel_2d, LaplaceKernel, HelmholtzKernel # noqa
from sumpy.kernel import OneKernel, LaplaceKernel, HelmholtzKernel # noqa

import faulthandler
faulthandler.enable()
Expand Down
2 changes: 1 addition & 1 deletion experiments/maxwell_sphere.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import pyopencl as cl
from sumpy.visualization import FieldPlotter
#from mayavi import mlab
from sumpy.kernel import one_kernel_2d, LaplaceKernel, HelmholtzKernel # noqa
from sumpy.kernel import OneKernel, LaplaceKernel, HelmholtzKernel # noqa

import faulthandler
faulthandler.enable()
Expand Down
4 changes: 2 additions & 2 deletions test/test_layer_pot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,9 @@ def test_unregularized_with_ones_kernel(actx_factory: ArrayContextFactory):
auto_where=("source", "target"),
)

from sumpy.kernel import one_kernel_2d
from sumpy.kernel import OneKernel
sigma_sym = sym.var("sigma")
op = sym.int_g_vec(one_kernel_2d, sigma_sym, qbx_forced_limit=None)
op = sym.int_g_vec(OneKernel(discr.ambient_dim), sigma_sym, qbx_forced_limit=None)

sigma = discr.zeros(actx) + 1

Expand Down
Loading