Skip to content

Fix exception flow: omit if_has_tag when "restrict to same tag" is unchecked #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Apr 30, 2026
Merged

Fix exception flow: omit if_has_tag when "restrict to same tag" is unchecked #1491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4618b82
Initial plan
Copilot Apr 30, 2026
073f9de
Fix exception flow: don't include if_has_tag when restrict_to_same_ta…
Copilot Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions course/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1187,13 +1187,11 @@ def grant_exception_stage_3(
# {{{ put together access rule

if form.cleaned_data["create_access_exception"]:
new_access_rule_json = {
new_access_rule_json: dict[str, object] = {
"permissions": [str(p) for p in permissions],
"if_has_tag": (
session.access_rules_tag
if restricted_to_same_tag else
None)
}
if restricted_to_same_tag:
new_access_rule_json["if_has_tag"] = session.access_rules_tag
# Ensure that JSON validates, but do not use it.
access_rule_ta.validate_python(new_access_rule_json, context=vctx)

Expand Down Expand Up @@ -1252,15 +1250,13 @@ def grant_exception_stage_3(
as_local_time(due_local_naive)
.replace(tzinfo=None))

new_grading_rule_json = {
new_grading_rule_json: dict[str, object] = {
"description": descr,
"due": due_local_naive,
"if_has_tag": (
session.access_rules_tag
if restricted_to_same_tag else
None),
"generates_grade": form.cleaned_data["generates_grade"],
}
if restricted_to_same_tag:
new_grading_rule_json["if_has_tag"] = session.access_rules_tag

def transfer_attr(name: str):
if form.cleaned_data[name] is not None:
Expand Down
Loading