fix(agents): Prevent Docker output pollution and skip agent pulling in container mode #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

edenreich wants to merge 5 commits into main from claude/issue-386-20260128-1108

Contributor

edenreich commented Jan 28, 2026

Summary

This PR fixes the issue where logs from the agents manager were going to stdout in container mode, breaking the TUI.

Changes

Container Detection: Added internal/utils/container.go to detect when CLI runs inside a container
Skip Docker-in-Docker: Modified agent and MCP managers to skip local startup in container mode
Redirect Output: All docker command output redirected to io.Discard to prevent TUI pollution
Dockerfile Update: Set INFER_IN_CONTAINER=true for explicit detection
Testing: Added unit tests for container detection

Testing

Run CLI in container mode: docker run --rm -it ghcr.io/inference-gateway/cli:latest
Verify no JSON logs appear in TUI
Verify remote agent discovery still works
Run unit tests: task test

Resolves #386

Generated with Claude Code


          fix(agents): Prevent Docker output pollution and skip agent pulling i…

a7f4758

…n container mode

- Add container detection utility to identify when CLI runs in container
- Skip local agent/MCP server startup when in container mode (no Docker-in-Docker)
- Only discover remote agents from config.a2a.agents when containerized
- Redirect docker command stdout/stderr to prevent TUI pollution
- Set INFER_IN_CONTAINER=true in Dockerfile for explicit detection
- Fixes logs from agents manager breaking TUI in container mode

Resolves #386

Co-authored-by: Eden Reich <edenreich@users.noreply.github.com>

edenreich commented

View reviewed changes

internal/services/agent_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/agent_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/agent_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/agent_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/agent_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/gateway_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/gateway_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/mcp_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/mcp_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/mcp_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/services/mcp_manager.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container_test.go Outdated Show resolved Hide resolved

edenreich commented

View reviewed changes

internal/utils/container.go Outdated Show resolved Hide resolved

edenreich added 4 commits

January 28, 2026 12:42


          chore: Apply suggestions from code review

e83f9e5


          chore: Apply suggestions from code review

00bad3d


          refactor: Remove outdated container detection comments

bdcc917


          chore: Merge branch 'main' into claude/issue-386-20260128-1108

61e7f70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet