Add unit tests for ProtobufUtil#710
Open
vasiliy-mikhailov wants to merge 1 commit into
Open
Conversation
tristantarrant
requested changes
Jul 3, 2026
tristantarrant
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution !
Most of the calls are invoking thin wrapper overloads, so I don't think they are worth the tests.
Please keep the tests for the following:
- testWriteToNullObject
- testFromEnumClass
- testEstimateSize
- testToByteBuffer / testFromByteBuffer
Member
|
Also, can you create an issue and format the commit message according to the commit rules ? |
vasiliy-mikhailov
force-pushed
the
add-ProtobufUtil-tests
branch
2 times, most recently
from
July 8, 2026 12:40
6e9833b to
c91399e
Compare
Author
|
Thanks @tristantarrant! Addressed both points:
Ready for another look whenever you have a moment. |
Member
|
Sorry, you need to adjust to the new Jupiter assertion method argument order (the message goes in last position now) |
vasiliy-mikhailov
force-pushed
the
add-ProtobufUtil-tests
branch
from
July 18, 2026 01:33
c91399e to
54f8810
Compare
Author
|
Thanks @tristantarrant! Addressed the Jupiter feedback:
Verified locally under JDK 17: 🤖 Addressed by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additive unit tests for
ProtobufUtil— edge cases and current behavior pinned with explicit assertions. No existing test or production code changed (append-only).Verified green under Java 17 (
mvn -pl core test -Dtest=ProtobufUtilTest→ 59 tests, 0 failures). On this class the additions raise line coverage from 42 to 65/69 lines and the PIT mutation kill-rate from 65 to 109/121 mutants.How this was produced
This PR was generated with an AI-assisted pipeline built around mutation testing (PIT). The pipeline mutates the target class (flipping conditions and changing boundary/edge cases) and runs the existing tests against each mutant. Where a mutant survives (the existing tests do not catch that edge case), it writes a focused test for that case and reruns PIT to confirm the new test actually kills that specific mutant. So every added test is verified to catch a concrete edge case the suite missed before, rather than being speculative or redundant. The change is additive only (no production code modified), and the module builds green under its CI JDK.