Merged
Conversation
guimroque
reviewed
Mar 12, 2026
| # PRIVY | ||
| VITE_PRIVY_APP_ID= | ||
| VITE_PRIVY_CLIENT_ID= No newline at end of file | ||
| VITE_PRIVY_APP_ID=cmdddunbk00njjf0nz6r5r3e9 |
Member
There was a problem hiding this comment.
🔴 CRITICAL: Sensitive credentials committed to repository
Problem: You're committing Privy App ID and Client ID directly to the repository. This violates our security standards which explicitly state "Nunca commitar: .env, tokens, secrets, credentials". These values will be visible in git history and accessible to anyone with repository access.
Suggestion:
- Remove these values from the commit
- Add them to your local
.env.productionfile (which should be gitignored) - Document the required environment variables in README or a
.env.examplefile - Use your deployment platform's environment variable configuration to set these in production
guimroque
reviewed
Mar 12, 2026
Member
guimroque
left a comment
There was a problem hiding this comment.
Code Review
Summary
This PR adds Privy environment variables to the production configuration. However, it commits sensitive credentials directly to the repository, which is a critical security violation according to our standards.
Strengths
- Clear and focused change addressing Privy configuration
- Proper file targeting for production environment
Issues
- 1 critical security issue that blocks merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist