Skip to content

FIX: add privy env vars#855

Merged
pedroanastacio merged 1 commit intostagingfrom
p2/chore/add-privy-config
Mar 12, 2026
Merged

FIX: add privy env vars#855
pedroanastacio merged 1 commit intostagingfrom
p2/chore/add-privy-config

Conversation

@pedroanastacio
Copy link
Copy Markdown
Contributor

Description

  • Add Privy env vars

Checklist

  • I reviewed my PR code before submitting
  • I ensured that the implementation is working correctly and did not impact other parts of the app
  • I implemented error handling for all actions/requests and verified how they will be displayed in the UI (or there was no error handling needed).
  • I mentioned the PR link in the task

Comment thread .env.production
# PRIVY
VITE_PRIVY_APP_ID=
VITE_PRIVY_CLIENT_ID= No newline at end of file
VITE_PRIVY_APP_ID=cmdddunbk00njjf0nz6r5r3e9
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CRITICAL: Sensitive credentials committed to repository

Problem: You're committing Privy App ID and Client ID directly to the repository. This violates our security standards which explicitly state "Nunca commitar: .env, tokens, secrets, credentials". These values will be visible in git history and accessible to anyone with repository access.

Suggestion:

  1. Remove these values from the commit
  2. Add them to your local .env.production file (which should be gitignored)
  3. Document the required environment variables in README or a .env.example file
  4. Use your deployment platform's environment variable configuration to set these in production

Copy link
Copy Markdown
Member

@guimroque guimroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Summary

This PR adds Privy environment variables to the production configuration. However, it commits sensitive credentials directly to the repository, which is a critical security violation according to our standards.

Strengths

  • Clear and focused change addressing Privy configuration
  • Proper file targeting for production environment

Issues

  • 1 critical security issue that blocks merge

@pedroanastacio pedroanastacio merged commit d8218f2 into staging Mar 12, 2026
1 of 3 checks passed
@pedroanastacio pedroanastacio deleted the p2/chore/add-privy-config branch March 12, 2026 19:41
@guimroque guimroque mentioned this pull request Mar 12, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants