FIX: remove commas before format vault balance in usd#864
Merged
Conversation
guimroque
reviewed
Mar 13, 2026
guimroque
reviewed
Mar 13, 2026
Member
guimroque
left a comment
There was a problem hiding this comment.
Code Review
Summary
The fix addresses a NaN display issue when formatting vault balances in USD with commas. The solution removes commas before parsing the number, which resolves the formatting problem. However, there are some implementation concerns around the utility function usage and formatting configuration.
Strengths
- Good use of useMemo for performance optimization in formatting calculations
- Proper null coalescing with fallback to '0' for undefined balances
- Clean import organization following project standards
Issues
- 1 important issue around potential utility function misuse
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the vault balance in USD is in the thousands or higher, the balance is displayed as NaN on the vault card
Summary
Checklist