feat: Accordion, Alert, Button Color Updates#826
Open
brandenTenbrink wants to merge 2 commits intofeat/clockface-color-refactor-masterfrom
Open
feat: Accordion, Alert, Button Color Updates#826brandenTenbrink wants to merge 2 commits intofeat/clockface-color-refactor-masterfrom
brandenTenbrink wants to merge 2 commits intofeat/clockface-color-refactor-masterfrom
Conversation
brandenTenbrink
requested review from
a team,
juliajames12 and
mavarius
as code owners
| withKnobs | ||
| ) | ||
|
|
||
| // There is no css stylijng for these unused enums |
Contributor
There was a problem hiding this comment.
Did you mean Styling?
| $c-chartreuse: #d6f622; | ||
| $c-magenta: #bf2fe5; | ||
| $c-deeppurple: #13002d; | ||
| $c- |
Contributor
There was a problem hiding this comment.
Seems like an extra newline sneaked in here?
| Tiger = '#F48D38', | ||
| Pineapple = '#FFB94A', | ||
| Thunder = '#FFD255', | ||
| //Thunder = '#FFD255', |
Contributor
There was a problem hiding this comment.
If we're trying to delete this color we should remove it instead of commenting it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changes
Updated the colors to include the new Clockface Colors.
Updated the following components:
Screenshots
// Add screenshots here if relevant
Checklist
Check all that apply