fix(influxdb3-ent): use image entrypoint and support extra env variables#799
Open
alespour wants to merge 6 commits into
Open
fix(influxdb3-ent): use image entrypoint and support extra env variables#799alespour wants to merge 6 commits into
alespour wants to merge 6 commits into
Conversation
alespour
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the influxdb3-enterprise Helm chart to rely on the container image entrypoint (enabling INFLUXDB3_UNSET_VARS) and adds per-component extraEnv support so environment overrides can be targeted to specific components.
Changes:
- Replace
command: /bin/sh -c ...withargs:across component StatefulSets to allow the image entrypoint to run, and introducePOD_NAMEvia the Downward API for stable--node-id. - Add component-scoped
extraEnvinvalues.yaml, document it in the README, and implement global+component env rendering in_helpers.tpl. - Add CI coverage values for component
extraEnv, bump chart/app versions, and update cert-manager install/wait logic in CI.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/influxdb3-enterprise/values.yaml | Adds per-component extraEnv and clarifies global vs component env behavior. |
| charts/influxdb3-enterprise/templates/_helpers.tpl | Introduces podNameEnv and componentExtraEnv helper templates. |
| charts/influxdb3-enterprise/templates/ingester-statefulset.yaml | Switches to args, uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/templates/querier-statefulset.yaml | Switches to args, uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/templates/compactor-statefulset.yaml | Switches to args, uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/templates/processor-statefulset.yaml | Switches to args (incl. init container), uses POD_NAME, and renders merged extra env. |
| charts/influxdb3-enterprise/README.md | Documents global and component-specific extraEnv and updates parameters table. |
| charts/influxdb3-enterprise/ci/component-extra-env-values.yaml | Adds CT install values to exercise per-component env + entrypoint unset behavior. |
| charts/influxdb3-enterprise/Chart.yaml | Bumps chart version and appVersion. |
| .github/workflows/helm-charts-test.yaml | Updates cert-manager install URL and replaces sleep with kubectl wait. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #798
entrypointfor containers. One of the benefits is thatINFLUXDB3_UNSET_VARSworks now.extraEnvvalues support; global with per-component overrides