docs(inputs.smartctl): Document sudo-rs incompatibility#18676
Merged
skartikey merged 2 commits intoinfluxdata:masterfrom Apr 16, 2026
Merged
docs(inputs.smartctl): Document sudo-rs incompatibility#18676skartikey merged 2 commits intoinfluxdata:masterfrom
skartikey merged 2 commits intoinfluxdata:masterfrom
Conversation
Contributor
|
Thanks so much for the pull request! |
telegraf-tiger
bot
added
docs
Contributor
Author
|
!signed-cla |
srebhan
reviewed
Apr 16, 2026
Comment on lines
+91
to
+95
| > [!NOTE] | ||
| > If your system uses the `sudo-rs` Rust-based rewrite of GNU `sudo`, the | ||
| > logging options in `Defaults!SMARTCTL` are not supported and will cause | ||
| > errors. There's not currently a native way to prevent voluminous logs with | ||
| > `use_sudo` enabled. See trifectatechfoundation/sudo-rs#1181. |
Member
There was a problem hiding this comment.
My concern is that nobody will remove this again once the sudo-rs bug will be resolved. So can we please change this to
Suggested change
| > [!NOTE] | |
| > If your system uses the `sudo-rs` Rust-based rewrite of GNU `sudo`, the | |
| > logging options in `Defaults!SMARTCTL` are not supported and will cause | |
| > errors. There's not currently a native way to prevent voluminous logs with | |
| > `use_sudo` enabled. See trifectatechfoundation/sudo-rs#1181. | |
| > [!NOTE] | |
| > 🪲 In case you are using `sudo-rs` instead of GNU's `sudo`, the logging options | |
| > `Defaults!SMARTCTL` has to be removed as it is not supported currently.and will cause | |
| > See trifectatechfoundation/sudo-rs#1181. |
including the 🪲 icon. This way we can grep for that icon and check if these "temporary" unwanted behaviors (or bugs ;-)) are still applicable...
Contributor
Author
There was a problem hiding this comment.
Sensible. I'll do that through a workspace commit as it looks like some formatting etc was lost here.
srebhan
changed the title
srebhan
approved these changes
Apr 16, 2026
srebhan
added
the
ready for final review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note compatibility issue for
sudo-rsoptions ininputs.smartctl.In passing, (1) note that sudoers config can be placed in
/etc/sudoers.dand (2) minor typo.Checklist
Related issues
resolves #18675