feat(inputs.smartctl): device name to attribute metrics#18679
Draft
hackery wants to merge 2 commits intoinfluxdata:masterfrom
Draft
feat(inputs.smartctl): device name to attribute metrics#18679hackery wants to merge 2 commits intoinfluxdata:masterfrom
hackery wants to merge 2 commits intoinfluxdata:masterfrom
Conversation
Optional `metric_version` flag changes tag usage in the `smartctl_attributes` metrics to make `name` the device name (consistent with its use in the `smartctl` metrics) and putting the attribute name in a new `attribute` tag.
telegraf-tiger
bot
added
feat
Hipska
approved these changes
Apr 9, 2026
| ## making it harder to associate them to the "smartctl" metrics. | ||
| ## metric_version = 2 will use the "name" tag for the the device name, | ||
| ## and a new "attribute" tag for the attribute name. | ||
| metric_version = 1 |
Contributor
There was a problem hiding this comment.
Default values can be commented out
Suggested change
| metric_version = 1 | |
| # metric_version = 1 |
Contributor
Author
|
@srebhan via Slack suggested using a more specific option like enforce_device_name_tag, and also asked for a unit test to be added. I hope to get to that today and will update PR. |
Contributor
|
If your PR is not ready to be reviewed, please mark it as Draft. |
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional
metric_versionflag changes tag usage in thesmartctl_attributesmetrics to makenamethe device name (consistent with its use in thesmartctlmetrics) and putting the attribute name in a newattributetag.I don't know if this is the correct way to achieve this.
metric_versionis used elsewhere for similar purposes, but here seems a bit of a sledgehammer for a single tag name change. Would welcome alternative suggestions and quite prepared for PR to be rejected.Checklist
Related issues
resolves #18385