fix(inputs.nftables): Handle plain string elements in set unmarshalling#18686
Merged
srebhan merged 1 commit intoinfluxdata:masterfrom Apr 16, 2026
Merged
Conversation
Statically defined nftables sets return plain strings in the elem array while dynamically added entries return objects. The empty elem struct could not unmarshal strings, causing a JSON unmarshalling error. Add a custom UnmarshalJSON that accepts any JSON value type since the plugin only counts elements. Closes influxdata#18685
telegraf-tiger
bot
added
fix
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Apr 16, 2026
Member
srebhan
left a comment
srebhan
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @skartikey!
srebhan
added
the
ready for final review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Statically defined nftables sets return plain strings in the elem array while dynamically added entries return objects. The empty elem struct could not unmarshal strings, causing a JSON unmarshalling error. Add a custom UnmarshalJSON that accepts any JSON value type since the plugin only counts elements.
Checklist
Related issues
resolves #18685