Add the smoke tests and fix the CI checks#620
Open
rsatal wants to merge 3 commits into
Open
Conversation
Contributor
Author
rsatal
force-pushed
the
smoke-tests
branch
2 times, most recently
from
e007c61 to
7e036c0
Compare
Regression introduced by f64afd9. The upgrade matrix leg builds & deploys konk-operator twice from two different working trees. Two changes from f64afd9 combined to break it: 1. GIT_VERSION switched from ?= to :=, so callers can no longer pin it across invocations. 2. New --set=relatedImages.{apiserver,provision,kind}=$(GIT_VERSION) overrides flow into the operator-managed runner-konk Helm release as overrideValues. With shifting GIT_VERSION the second deploy rewrites the release and host-side 'helm test runner-konk' fails with 'release: not found'. Restore ?= for GIT_VERSION; pin it once in the upgrade leg's first install step and propagate via $GITHUB_ENV. Also run the helm-releases debug group via infoblox/helm:3 docker image since the GitHub runner has no helm CLI installed.
Contributor
|
Why is k6 being used to test the contract for a custom resource? There are better tools for testing controllers if that is the intent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes for adding the smoke tests and a fix for CI failures
### Smoke tests
### 2. CI fix — upgrade matrix leg
