feat: add support for reading request body from file #108
Merged
Conversation
rajat-tomar
requested changes
Mar 26, 2026
There was a problem hiding this comment.
Mutual exclusion check and error wrapping are good but three things to address:
- Config file merge is incomplete — see inline comment on configfile.go
- Needs tests.
config_test.goalready has a table-driven Validate suite with thevalidConfig()helper. Add cases for: both-band-Dset (should error), nonexistent file (should error), valid file (Body should be populated after Validate) - Fix the usage example in this PR description —
goperf.exe run -- POST -D payload.jsonwon't work. The--means end-of-flags, soPOSTbecomes the URL argument. Should be:goperf run -m POST -D payload.json https://httpbin.org/post
rajat-tomar
approved these changes
Mar 26, 2026
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for reading the request body from a file using the
-D(--body-file) flag. This simplifies handling large or complex payloads that are difficult to pass via CLI.Changes
-D, --body-file <file_path>flag to read request body from a file-bflag-band-DUsage
goperf run -m POST -D payload.json https://httpbin.org/post
Why
Previously, request bodies could only be passed using -b, which becomes inconvenient for large JSON payloads. This improves usability and supports real-world scenarios.
Testing