Support PHP 8.4 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoulton
approved these changes
Jul 23, 2025
Member
acoulton
left a comment
acoulton
left a comment
There was a problem hiding this comment.
We could just release as 1.2.0 (we did 1.1.0 for switching to PHP 8.3). Composer will deal with only taking that if it's on a compatible platform.
Alternatively we could support multiple versions if we wanted, would just have to parameterise the docker-compose.yaml to take the PHP image from an env var and give github actions a matrix build. But maybe not worth it at this point?
Member
Author
|
Think we should just release it as 1.2.0 then. Theres no benefit to supporting multiple PHP versions of this, at least at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should probably be released as next major ie 2.x Nothing breaking but we can only support & test on one platform at a time and no need to continue 8.3 support after we've migrated to 8.4