fix for UNKNOWN version when tagged by couchbase#16
Open
steveyen wants to merge 1 commit intoingenthr:masterfrom
Open
fix for UNKNOWN version when tagged by couchbase#16steveyen wants to merge 1 commit intoingenthr:masterfrom
steveyen wants to merge 1 commit intoingenthr:masterfrom
Conversation
Change-Id: Ieaf49916e80458b52e58616a07b0a7971842e329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this fixes that UNKNOWN version when building this. The issue is that github.com/couchbase/memcachetest had a tag ("couchbase_1.8.0") that made git describe emit output ("couchbase_1.8.0-6-g35fd1b9") that version.pl didn't know how to parse.
Steve