feat: add storage api #64
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
prestwich
force-pushed
the
prestwich/storage-api
branch
from
7152b93 to
67c6c16
Compare
Evalir
reviewed
Jan 15, 2026
crates/storage/src/hot/db.rs
Outdated
| if self.write_locked.swap(true, Ordering::AcqRel) { | ||
| return Err(HotKvError::WriteLocked); | ||
| } | ||
| self.inner.writer().map(Some).map(|tx| WriteGuard { tx, db: self }) |
Member
There was a problem hiding this comment.
If this fails, no WriteGuard is created, which is the only way self.write_locked is set back to false. Won't this mean an error when calling writer will erroneously lock writes forever?
Member
Author
|
don't review this PR yet |
prestwich
force-pushed
the
prestwich/storage-api
branch
from
8edb0f6 to
bfab627
Compare
prestwich
changed the base branch from
graphite-base/64
to
prestwich/reth-1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One day's work on re-architecting reth DB with a hot/cold model