Draft
Conversation
Co-authored-by: Sawit Trisirisatayawong <tansawit@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
Deploying interwovenkit with
|
| Latest commit: |
58c4a92
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d50fb316.interwovenkit.pages.dev |
| Branch Preview URL: | https://cursor-sign-in-wallet-priori.interwovenkit.pages.dev |
Deploying interwovenkit-staging with
|
| Latest commit: |
58c4a92
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6406cd3.interwovenkit-staging.pages.dev |
| Branch Preview URL: | https://cursor-sign-in-wallet-priori.interwovenkit-staging.pages.dev |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying interwovenkit-testnet with
|
| Latest commit: |
58c4a92
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80c1388e.interwovenkit-testnet.pages.dev |
| Branch Preview URL: | https://cursor-sign-in-wallet-priori.interwovenkit-testnet.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prioritize owned popular wallets in sign-in suggestions when the number of ready wallets exceeds the display limit.
This ensures that users with many installed wallets see their popular ones (e.g., MetaMask, Rabby) first in the limited 5-slot display on the sign-in page, improving discoverability without reordering when within the limit.
Note
Low Risk
Small, UI-only ordering change gated to cases with many ready wallets; includes unit tests and doesn’t affect connection/auth flows.
Overview
Updates the sign-in wallet suggestion list to prioritize installed wallets that match a curated popular-wallet set (by id or normalized name) when there are more ready connectors than the 5-slot display limit, while preserving the original ordering when within the limit.
Introduces reusable
prioritizeSignInWalletslogic plus Vitest coverage, and replaces the previous simpleslice(0, 5)selection inSignIn.tsxwith this prioritization and a sharedSIGN_IN_WALLET_LIMITconstant.Written by Cursor Bugbot for commit 58c4a92. This will update automatically on new commits. Configure here.