Reloadable dochandles - #28
Open
paulsonnentag wants to merge 19 commits into
Open
Conversation
This reverts commit 9a65903.
…y re-pointing" This reverts commit c2a282c.
…riptors Checkpoint-only moves (scrubbing rewrites CheckedOutDraft.at) now re-answer every live repo:handle-descriptor subscription with freshly pinned backing urls, so OverlayRepo swaps handle backings in place instead of the main view remounting. DocumentAreaRoot drops pinnedDocUrl and keys the main view on the plain selected doc url. Stale in-flight resolutions are gated by a per-batch AbortController (replacing the switchEpoch counter).
Scrubbing history / switching drafts swaps a live handle's backing (change event with scopeReplaced: true); the old undo entries describe a different timeline, so both editors now drop their stacks on that event: - codemirror-base owns history()/historyKeymap in a compartment (createHistoryExtension) and cycles it out and back in on scopeReplaced -- CodeMirror has no clear-history API, and single ownership matters because the history state field is a module-level singleton. codemirror-markdown no longer registers its own history. - the sync plugin's full-doc rebuild dispatch is annotated addToHistory: false + remote: true, so the swap itself is never undoable and the reset is order-independent. - tldraw4 clears the editor's stack via useClearHistoryOnScopeSwap in the automerge bindings (editor-level hook: the HistoryManager only exists once <Tldraw> mounts, so this can't live in useAutomergeStore). Remote automerge patches entering the local undo history is a separate upstream issue (automerge-codemirror PR pending).
Paint the timeline indicator (dot + line) on top of the group rows and always draw it in the foreground color. Drop the "current" badge; in its place the card title shows a "Return to latest" pill while the timeline is pinned. Dragging the scrubber all the way to the top now returns to the live latest version instead of freezing at the newest change.
…ache docs The sidebar re-ran Automerge.diff over every change on each edit to group history, blocking the main thread. A fill engine now computes activity groups in idle-time slices and persists them in a change-group-cache doc linked from each draft; the sidebar renders straight from the cache and resolves scrub positions on demand from change metadata (no diffs).
…iffs Scrubbing wrote from=to (no diff) and live drafts always diffed against their fork point via an implicit provider fallback, so diffs were neither visible when scrubbing nor controllable. The checkpoint's per-doc `from` is now the only baseline authority: an eye toggle in the card title writes it — group-start heads when pinned to a group (the baseline stays anchored while scrubbing within it), fork-point heads on a live draft — and the fallback is gone, so closing the eye simply removes the baselines. "Return to latest" moves left; the eye sits right.
…f's from point Plus timeline polish: selecting a group re-anchors the baseline to its start, GitHub-style relative times, softer scrubber lines and selection styling, no group-row highlight, 10-minute grouping gap, and a tooltip on the disabled eye.
Collaborator
✅ Patchwork glance readyhttps://patchwork-preview-28--patchwork-base.netlify.appPatchwork from |
…erge up, delete Drag-to-fork and the New draft button are gone; a selected card's "..." menu now forks at the latest heads or at the scrubbed version, merges a draft up into the draft it was forked off (hover highlights the target card), and deletes a draft after a confirm dialog. Drafts track their parent, list depth-first, and render indented beneath Main. Merged drafts hide from the list; the scrubber sticker drops the doc title.
…hile the eye is open The scrubber sticker used to diff only the single change under the head, so extending the baseline never changed its +/- counts. It now reads the live checkpoint and sums each member's from -> to diff. Also: headroom above the head line so the dot and sticker stop crowding the card header, the selected header keeps the card's color, and the version footer is gone (the version still logs to the console).
…et stable "Draft N" names
…s are identifiable
…les (drafts cache, actor attribution, codemirror history)
…y extension tracks isReadOnly() live and the comment UI disables writes while read-only
…dOnly() live and gate the store write-back behind a ref; align tldraw4's automerge-repo pins with @automerge/react
The list provider mirrors the checked-out draft into the URL (replaceState, so no re-route or history spam) and applies an incoming draft= once the draft appears in this doc's tree — so links work even before the draft doc has synced. The router clears the param when navigating to another doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Make drafts good enough for daily usage. We should do a proper exploration of this but in the meantime we need a basic version of drafts that works.
Fixes
Todos