servershell: speed up result table rendering#457
Open
seqizz wants to merge 1 commit into
Open
Conversation
Selecting and working on many objects is slow because of the current per-row jQuery construction and per-cell linear scans. This commit tries to speed up via multiple changes. Feels much snappier but don't have a solid benchmark yet. Mostly work of Opus, still sending all the inputs through escape_html to avoid XSS. - Rewrite update_result/get_row_html to build the body as one HTML string (single innerHTML) instead of per-element jQuery construction. - Precompute O(1) lookups per redraw (object/attribute/deleted/changed) instead of linear scans per cell. - Snapshot the servershell Proxy properties used in the loop (each access dispatches events). - Event delegation for inline-edit and relation links instead of per-cell/per-link handlers. - set_selected O(rows) instead of O(selected * rows). - Fix delete to redraw once instead of once per selected object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting and working on many objects is slow because of the current per-row jQuery construction and per-cell linear scans. This commit tries to speed up via multiple changes. Feels much snappier but don't have a solid benchmark yet.
Mostly work of Opus, still sending all the inputs through escape_html to avoid XSS.