Skip to content

Adding hi res domains#71

Merged
spiani merged 28 commits into
mainfrom
hi_res
Feb 20, 2026
Merged

Adding hi res domains#71
spiani merged 28 commits into
mainfrom
hi_res

Conversation

@vdibiagio

Copy link
Copy Markdown
Collaborator

No description provided.

@spiani spiani marked this pull request as ready for review February 20, 2026 22:29
Copilot AI review requested due to automatic review settings February 20, 2026 22:29
@spiani spiani merged commit 25087f0 into main Feb 20, 2026
7 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds high-resolution domain configurations for multiple Italian coastal regions. The changes include both river configuration files (JSON) and domain configuration files (YAML) that define bathymetry processing, river digging, and other oceanographic modeling parameters for these new high-resolution domains.

Changes:

  • Added 6 new river configuration JSON files (PES, LAM, ISO, GOR, GAE, CAG) defining river geometry for domain-specific overrides
  • Added 11 new high-resolution domain YAML files defining domain boundaries, bathymetry settings, and processing actions for regions including Pescara, Panarea, Naples, Lamezia, Isonzo, Gulf of Trieste, Gorizia, Gaeta, Follonica, Conero, and Cagliari
  • Updated HGT.json to refine river configurations (Timavo and Isonzo) with more precise mouth coordinates and width parameters

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mer_domains/rivers/PES.json Defines Pescara river geometry with stem configuration for PES domain
mer_domains/rivers/LAM.json Defines Amato river geometry with stem configuration for LAM domain (contains formatting issue)
mer_domains/rivers/ISO.json Defines Isonzo river geometry with stem, mouth coordinates, and width for ISO domain
mer_domains/rivers/HGT.json Updates Timavo and Isonzo river configurations with refined mouth coordinates and width parameters
mer_domains/rivers/GOR.json Defines Reno river geometry with width parameter for GOR domain
mer_domains/rivers/GAE.json Defines Garigliano river geometry with mouth coordinates and width for GAE domain
mer_domains/rivers/CAG.json Defines Mannu river geometry with stem_flux model for CAG domain
mer_domains/high_reso/pes.yaml Configuration for Pescara high-resolution domain with river digging and tile generation
mer_domains/high_reso/pan.yaml Configuration for Panarea high-resolution domain with multiple depth adjustments and channel digging
mer_domains/high_reso/nap.yaml Configuration for Naples high-resolution domain with river digging and channel operations
mer_domains/high_reso/lam.yaml Configuration for Lamezia high-resolution domain with river digging
mer_domains/high_reso/iso.yaml Configuration for Isonzo high-resolution domain with linear interpolation and channel digging
mer_domains/high_reso/hgt.yaml Updates Gulf of Trieste domain coordinates and adds new depth fixes and channel operations
mer_domains/high_reso/gor.yaml Configuration for Gorizia high-resolution domain with linear interpolation
mer_domains/high_reso/gae.yaml Configuration for Gaeta high-resolution domain with river digging
mer_domains/high_reso/fol.yaml Configuration for Follonica high-resolution domain without river operations
mer_domains/high_reso/con.yaml Configuration for Conero high-resolution domain with linear interpolation
mer_domains/high_reso/cag.yaml Configuration for Cagliari high-resolution domain with river digging

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"geometry": {
"side": "E",
"stem": [
"7z"

Copilot AI Feb 20, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stem value "7z" is missing a sign prefix. Based on the codebase conventions, stem values should always include a sign prefix (+ or -). All existing stem values in the codebase follow this pattern (e.g., "+2z", "-45z", "+10m"). This should be either "+7z" or "-7z" depending on the intended direction.

Suggested change
"7z"
"+7z"

Copilot uses AI. Check for mistakes.
@spiani spiani deleted the hi_res branch February 20, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants