Skip to content

Fix misleading comment on water_cells in dig_rivers.py #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spiani merged 2 commits into from
Mar 12, 2026
Merged

Fix misleading comment on water_cells in dig_rivers.py #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6f72bc
Initial plan
Copilot Mar 12, 2026
8361fd8
Fix misleading comment about water_cells usage in dig_rivers.py
Copilot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/bathytools/actions/dig_rivers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,9 @@ def __call__(self, bathymetry: xr.DataArray) -> xr.DataArray:
allow_broadcast=True,
)

# Check if a side is "open", i.e., if it has at least one water cell
# Precompute a boolean array of cells that are already underwater
# (negative bathymetry). Used later to skip water cells when tracking
# river dig cells for intersection detection.
b_array = bathymetry.elevation.transpose(
"latitude", "longitude"
).values
Expand Down
Loading