Add tides computation as boundary condition for MITgcm#10
Open
apetronio-OGS wants to merge 13 commits into
Open
Add tides computation as boundary condition for MITgcm#10apetronio-OGS wants to merge 13 commits into
apetronio-OGS wants to merge 13 commits into
Conversation
…e or by arguments
…ided by configuration files or by arguments
New version of add_tides_bc scripts with bugs corrected and code refactored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from template matlab scripts, based on matlab library "tmd", I provied a first re-coding in python, taking advantage of the pyTMD library pyTMD, source code available here.
There are 2 py files, set_bc_grid and set_bc_tides: the first one to prepare the boundary files from the MITgcm grid, and the latter for the computation of the tideal constituents. Typical usage is to run the first and then the second.
The inputs can be provided by means of a sonfiguration file in json format, or as arguments of the function via command line.
At this stage there is a debug flag to print out some variables, and to check them against the old tides computed by dr. S. Querin for the case of "run_160p_AZAL_HR_for_grid".
Respect to the matlab outputs there are small to large discrepancies due to two main factor:
Egbert, Gary D., and Svetlana Y. Erofeeva. "Efficient inverse modeling of barotropic ocean tides." Journal of Atmospheric and Oceanic Technology 19.2 (2002): 183-204.