Skip to content

Nudging indices must contain only 0 and 1#23

Merged
spiani merged 1 commit into
mainfrom
fix_nudging_indices
Mar 19, 2026
Merged

Nudging indices must contain only 0 and 1#23
spiani merged 1 commit into
mainfrom
fix_nudging_indices

Conversation

@spiani

@spiani spiani commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 19, 2026 00:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates MITgcm open-boundary index generation so the nudging (nudgOB_*) arrays contain only binary values (0/1), matching the requirement implied by the PR title.

Changes:

  • Derive a nudging_cells array by mapping closed cells to 0 and open cells to 1.
  • Emit nudgOB_* values from nudging_cells instead of the raw sponge_cells values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@spiani spiani merged commit fe7d7dd into main Mar 19, 2026
5 checks passed
@spiani spiani deleted the fix_nudging_indices branch March 19, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants