Added a new script to generate a mask without rivers#25
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new mitgcm_inputs cosmetic_mask subcommand to generate a “cosmetic” meshmask with river cells removed (optionally in a MER/CF-compliant NetCDF layout), wires it into the main CLI entrypoint, and updates the MER statics launcher to produce/use that mask.
Changes:
- Added
cosmetic_maskCLI command to build a river-free mask and write it to NetCDF (with optional--meroutput format). - Registered the new command in
src/mitgcm_inputs/__main__.pyso it’s available viapoetry run mitgcm_inputs cosmetic_mask .... - Updated the MER statics generation script to create
cmeshmask.nc(or copymeshmask.ncwhen no rivers).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/mitgcm_inputs/cosmetic_mask/__init__.py |
New cosmetic mask command implementation and CLI argument definitions. |
src/mitgcm_inputs/__main__.py |
Registers the new subcommand and updates FLUXES executor naming. |
launcers/all_statics/generate_mer_statics.sh |
Generates cmeshmask.nc and passes options to downstream commands. |
poetry.lock |
Dependency lockfile updated (Poetry version + resolved deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.