Skip to content

Added a new script to generate a mask without rivers#25

Merged
spiani merged 2 commits into
mainfrom
cosmetic_masks
Mar 25, 2026
Merged

Added a new script to generate a mask without rivers#25
spiani merged 2 commits into
mainfrom
cosmetic_masks

Conversation

@spiani

@spiani spiani commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@spiani spiani self-assigned this Mar 24, 2026
Copilot AI review requested due to automatic review settings March 24, 2026 16:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new mitgcm_inputs cosmetic_mask subcommand to generate a “cosmetic” meshmask with river cells removed (optionally in a MER/CF-compliant NetCDF layout), wires it into the main CLI entrypoint, and updates the MER statics launcher to produce/use that mask.

Changes:

  • Added cosmetic_mask CLI command to build a river-free mask and write it to NetCDF (with optional --mer output format).
  • Registered the new command in src/mitgcm_inputs/__main__.py so it’s available via poetry run mitgcm_inputs cosmetic_mask ....
  • Updated the MER statics generation script to create cmeshmask.nc (or copy meshmask.nc when no rivers).

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.

File Description
src/mitgcm_inputs/cosmetic_mask/__init__.py New cosmetic mask command implementation and CLI argument definitions.
src/mitgcm_inputs/__main__.py Registers the new subcommand and updates FLUXES executor naming.
launcers/all_statics/generate_mer_statics.sh Generates cmeshmask.nc and passes options to downstream commands.
poetry.lock Dependency lockfile updated (Poetry version + resolved deps).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/mitgcm_inputs/cosmetic_mask/__init__.py
Comment thread src/mitgcm_inputs/cosmetic_mask/__init__.py Outdated
Comment thread src/mitgcm_inputs/cosmetic_mask/__init__.py Outdated
Comment thread src/mitgcm_inputs/cosmetic_mask/__init__.py Outdated
Comment thread launcers/all_statics/generate_mer_statics.sh
Comment thread launcers/all_statics/generate_mer_statics.sh
@spiani spiani merged commit 63541c5 into main Mar 25, 2026
1 check passed
@spiani spiani deleted the cosmetic_masks branch March 25, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants