Remove warnings and fixing tests#14
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on reducing warnings and stabilizing tests by tightening config validation, updating test fixtures, and avoiding eager xarray imports in EFAS code.
Changes:
- Add
bgc_profilesto the test config fixture sobiogeochemical_profilereferences resolve. - Add explicit validation/error for undefined
biogeochemical_profilereferences during config loading. - Introduce a lazy
xarrayproxy and switch EFAS manager imports/type annotations to avoid eagerxarrayimport.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures.py | Extends the sample JSON fixture with bgc_profiles used by test rivers. |
| src/ogs_riverger/utils/lazy_xarray.py | Adds a module-level lazy proxy to defer importing xarray until first attribute access. |
| src/ogs_riverger/read_config.py | Adds validation for missing/undefined biogeochemical profile references. |
| src/ogs_riverger/efas/efas_manager.py | Replaces eager xarray import with the lazy proxy and updates annotations to avoid runtime evaluation. |
| pyproject.toml | Adjusts dev dependency constraints for deptry and pytest-asyncio. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.