Skip to content

Remove warnings and fixing tests#14

Merged
spiani merged 3 commits into
mainfrom
remove_warnings
Jun 24, 2026
Merged

Remove warnings and fixing tests#14
spiani merged 3 commits into
mainfrom
remove_warnings

Conversation

@spiani

@spiani spiani commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 24, 2026 10:10
@spiani spiani self-assigned this Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR focuses on reducing warnings and stabilizing tests by tightening config validation, updating test fixtures, and avoiding eager xarray imports in EFAS code.

Changes:

  • Add bgc_profiles to the test config fixture so biogeochemical_profile references resolve.
  • Add explicit validation/error for undefined biogeochemical_profile references during config loading.
  • Introduce a lazy xarray proxy and switch EFAS manager imports/type annotations to avoid eager xarray import.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/fixtures.py Extends the sample JSON fixture with bgc_profiles used by test rivers.
src/ogs_riverger/utils/lazy_xarray.py Adds a module-level lazy proxy to defer importing xarray until first attribute access.
src/ogs_riverger/read_config.py Adds validation for missing/undefined biogeochemical profile references.
src/ogs_riverger/efas/efas_manager.py Replaces eager xarray import with the lazy proxy and updates annotations to avoid runtime evaluation.
pyproject.toml Adjusts dev dependency constraints for deptry and pytest-asyncio.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ogs_riverger/utils/lazy_xarray.py Outdated
Comment thread src/ogs_riverger/read_config.py Outdated
Comment thread src/ogs_riverger/read_config.py
Comment thread pyproject.toml
@spiani spiani force-pushed the remove_warnings branch from bc620bf to 9a49636 Compare June 24, 2026 10:30
@spiani spiani merged commit 86ae9c6 into main Jun 24, 2026
4 checks passed
@spiani spiani deleted the remove_warnings branch June 24, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants