Improved var_aggregator.py using a dummy communicator#45
Open
spiani wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates var_aggregator.py to support serial execution without requiring MPI, switches console output from print to logging, and tightens CLI argument parsing by using typed pathlib.Path arguments.
Changes:
- Add a serial mode using a dummy communicator when
--serialis set (avoids importing/using MPI). - Replace
printcalls with a logger-based output approach. - Make argparse more robust by using typed path validators (
existing_dir_path,existing_file_path, etc.).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
spiani
force-pushed
the
serial_var_aggregator
branch
from
1131581 to
bd352fb
Compare
Added the possibility to run the var_aggregator.py script in serial mode, without importing and using MPI. This commit also replaces the print calls with a logging mechanism and makes the argparse more robust by specifying types and using path instead of strings.
spiani
force-pushed
the
serial_var_aggregator
branch
from
bd352fb to
d928500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the possibility to run the var_aggregator.py script in serial mode, without importing and using MPI.
This commit also replaces the print calls with a logging mechanism and makes the argparse more robust by specifying types and using path instead of strings.