Skip to content

Remove circular test dependency #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NSeydoux wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Remove circular test dependency #1564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4888190
Remove circular test dependency
NSeydoux Jun 4, 2026
ff96288
Drop support for Node 20
NSeydoux Jun 4, 2026
6db4ebe
Fix changelog
NSeydoux Jun 18, 2026
77fa3d4
Merge branch 'main' into fix/remove-authn-node-dependency
NSeydoux Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: 22.x
node-version-file: ".nvmrc"
cache: npm
- run: npm ci
- run: npm run build
Expand Down
3 changes: 1 addition & 2 deletions e2e/node/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import {
getAuthenticatedSession,
getNodeTestingEnvironment,
} from "@inrupt/internal-test-env";
import type { Session } from "@inrupt/solid-client-authn-node";
import {
describe,
it,
Expand Down Expand Up @@ -101,7 +100,7 @@ const env = getNodeTestingEnvironment({
});
describe("End-to-end verifiable credentials tests for environment", () => {
let vcSubject: string;
let session: Session;
let session: Awaited<ReturnType<typeof getAuthenticatedSession>>;
let issuerService: string;
let derivationService: string;
let statusService: string;
Expand Down
Loading