Support yaml deserialize function arg#114
Open
dmwelch wants to merge 2 commits intoinsightindustry:developfrom
Open
Support yaml deserialize function arg#114dmwelch wants to merge 2 commits intoinsightindustry:developfrom
dmwelch wants to merge 2 commits intoinsightindustry:developfrom
Conversation
- Simplified logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @insightindustry,
I noticed that this arg in
parse_yamlwasn't being used and since PyYAML doesn't support YAML > 1.2, I'd like to use ruamel.yaml.load in it's place. Here's my fix - let me know what you think.Cheers!
P.S. Sorry for the duplicate PRs - I realized I should make this to the
developbranch if I wanted to see it in v0.8.0!